Commit hash not found in PHPStorm
complete
P
Paul
I am getting a lot of errors in PHPStorm:
> Something went wrong: The commit hash previously reported no longer exists on this repository.
I presume this is because a tech debt item was reported against a branch commit, and then later the branch was squash-merged into trunk and deleted. This means that the commit that the tech debt was reported against no longer exists in our history.
As a result, PHPStorm is unable to show errors reported against rebased commits.
P
Paul
Hi Nick Omeyer, apologies for the late reply, I was on annual leave. I'll look at how much of our codebase this affects and will reply once I have a better idea. Please bear with me, this may take a few weeks depending on my current workload.
Nick Omeyer
complete
Hey Paul, we've released a couple of patches for this.
(1) We no longer show these error messages.
(2) We display an annotation at the top of the relevant file for all debt reports submitted from commits that were eventually squashed (rather than not showing any annotation at all). Figuring out how to locate the code of debt reports submitted from squashed commits is quite complex 😕 I'd be curious to hear what proportion of the Stepsize annotations you see are at the top of the file vs attached to the right piece of code, and to hear your thoughts on how important it is for you all to see these annotations at the code level rather than just at the file level 🙏
Nick Omeyer
Hey Paul, thanks for letting us know 🙏 Keeping track of these report locations in all scenarios is quite a challenge 😅
I'm trying to assess the severity of this issue for City Pantry – I'm assuming that the majority of your tech debt reports are submitted from feature branches, and these feature branches are eventually squash-merged into trunk. Is that right?
If that's the case, it should mean that the editor awareness feature is basically not functional for you and you haven't seen any inline annotations for past reports that were submitted from old branches, right? And all the code location links on our website 404 on GitHub too?
How significantly does that get in the way of your team's use of Stepsize?
Nick Omeyer
under review
Alaa Bouayed
Hey Paul
We've taken a quick look. It seems that you've pointed out two concerns, the first being numerous error notifications while the second is more about how our algorithm handles squash merge git flows.
For the first concern, we have submitted a new extension version which suppresses some of the error notifications you've been seeing. It'll be released once JetBrains approve it (usually takes approximately 1 day).
Regarding the second, which is understandably a bit more complex, you've correctly pointed out that our algorithm doesn't yet support squash merge git flows. We will look into possible ways of enhancing our algorithm during our next sprint planning session.
Please let us know if we've missed something or if the upcoming version doesn't improve on some of the concerns you have raised 😊
Alaa Bouayed
Hi Paul 👋
Thanks for bringing this to our attention, sorry if it has caused you any inconvenience!
We'll reproduce and get back to you with more information as soon as possible.